fix(prerender): avoid detecting .json routes as implicit html
#1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Nov 28, 2023
| @@ -220,7 +220,9 @@ export async function prerender(nitro: Nitro) { | |||
| // Guess route type and populate fileName | |||
| const contentType = res.headers.get("content-type") || ""; | |||
| const isImplicitHTML = | |||
| !route.endsWith(".html") && contentType.includes("html"); | |||
| !route.endsWith(".html") && | |||
| !route.endsWith(".json") && | |||
There was a problem hiding this comment.
We could also add .xml perhaps...
There was a problem hiding this comment.
Yeah, we could make a list also (for like . webmanifest ) but consider this is mainly a hotfix for when content-type is also wrongly text/html...
There was a problem hiding this comment.
A safelist is probably not a bad idea given this is only for implicit content type...
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
On investigation, there are cases where a framework renderer, returns
text/htmlresponses for routes ending with.jsonextension. Content is most likely also wrong (it does not fix nuxt/nuxt#24487 only generatesmanifest.jsonwith HTML in it!) but at least avoids making wrong structure.(root cause is that Nuxt ordering is different and first prerenders and then copies public assets)
📝 Checklist