Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-lambda): join cookies with semicolon #356

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix(aws-lambda): join cookies with semicolon #356

merged 1 commit into from
Aug 24, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 20, 2022 •
edited
Loading

🔗 Linked issue

nuxt/nuxt#14335, possibly nuxt/nuxt#13520.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes a typo where we are joining cookies with comma rather than semicolon.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 20, 2022
@danielroe danielroe requested a review from pi0 July 20, 2022 12:44
@danielroe danielroe self-assigned this Jul 20, 2022
@danielroe danielroe changed the title fix: join cookies with semicolon fix(aws-lambda): join cookies with semicolon Jul 20, 2022
@danielroe danielroe mentioned this pull request Jul 21, 2022
Merged
7 tasks
@pi0 pi0 merged commit cc6fac8 into main Aug 24, 2022
@pi0 pi0 deleted the fix/lambda-cookie-join branch August 24, 2022 19:11
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
@danielroe @WinterYukky
fix(aws-lambda): join cookies with semicolon (unjs#356)
e0303e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0