Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused @types/jsdom from dependencies #429

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

farnabaz
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #429 (187f2d4) into main (76e9ad8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   56.21%   56.21%           
=======================================
  Files          54       54           
  Lines        3467     3467           
  Branches      366      366           
=======================================
  Hits         1949     1949           
  Misses       1165     1165           
  Partials      353      353           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❀️

@danielroe
Copy link
Member

Context was nuxt/framework#104 but I think not needed any more.

@pi0 pi0 merged commit 1d02d01 into main Aug 18, 2022
@pi0 pi0 deleted the chore/remove-jsdom-types branch August 18, 2022 11:44
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants