-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Base64
type support
#8
Conversation
Welcome to Codecov πOnce you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered βοΈ |
Hi @itpropro thanks for PR β€οΈ I have played little bit locally and merged url-safe version as an optional option of Merging this but later add more tests to make sure all utils works as expected. |
Base64
type support
I tried to stay as close to the other exposed interfaces and therefore created a separate url type to avoid additional tests and parameters as non of the others had them. The |
π Linked issue
#6
β Type of change
π Description
Added
Base64
andBase64Url
types. There are exclusions in the tests, as bothBase64
types cannot autodetected, as they are semantically overlapping with string. Therefore a new optional parameter forconvertTo
was introduced to overwrite the autodetection for thefromType
.This was the best way I found to keep the tests simple and to change as least of the api exposure as possible. Detection of the types is still implemented, but explicitly not integrated in
detectType
due to the detection overlap withstring
mentioned above.π Checklist