Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix toType mapping #9

Merged
merged 2 commits into from
Apr 29, 2024
Merged

fix: fix toType mapping #9

merged 2 commits into from
Apr 29, 2024

Conversation

itpropro
Copy link
Member

@itpropro itpropro commented Apr 4, 2024

πŸ”— Linked issue

#7

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Added tests to cover the to{TYPE} functions
  • Fixed a bug in the mapping of toType functions
  • Fixed typo of the Uint8 type

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.84%. Comparing base (355cd94) to head (4fd66b3).
Report is 1 commits behind head on main.

Files Patch % Lines
src/convert.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   87.13%   87.84%   +0.70%     
==========================================
  Files          15       15              
  Lines        1127     1127              
  Branches       92      101       +9     
==========================================
+ Hits          982      990       +8     
+ Misses        143      135       -8     
  Partials        2        2              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@itpropro itpropro mentioned this pull request Apr 4, 2024
8 tasks
@pi0 pi0 changed the title fix: Fixed toType mapping, added tests fix: fix toType mapping Apr 29, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 915efa2 into main Apr 29, 2024
4 checks passed
@pi0 pi0 deleted the fix/toTypeFunctions branch April 29, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants