Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: transform ol->li to Steps component. #83

Merged
merged 8 commits into from
Mar 13, 2024
Merged

feat: transform ol->li to Steps component. #83

merged 8 commits into from
Mar 13, 2024

Conversation

cpreston321
Copy link
Member

@cpreston321 cpreston321 commented Mar 1, 2024 •
edited

🔗 Linked issue

#84

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Transform ol->li into the steps component by just using markdown.

Preview

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Mar 1, 2024 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4725eb9
Status: ✅  Deploy successful!
Preview URL: https://e9b863ce.undocs.pages.dev
Branch Preview URL: https://feat-steps.undocs.pages.dev

View logs

@cpreston321 cpreston321 changed the title feat(app): Steps component feat: Steps component Mar 1, 2024
pi0
pi0 reviewed Mar 2, 2024
View reviewed changes
docs/1.guide/components.md Outdated Show resolved Hide resolved
@cpreston321 cpreston321 closed this Mar 4, 2024
@cpreston321 cpreston321 reopened this Mar 13, 2024
@cpreston321 cpreston321 requested review from Atinux and pi0 March 13, 2024 18:04
@cpreston321 cpreston321 changed the title feat: Steps component feat: transform ol->li to Steps component. Mar 13, 2024
@cpreston321
Copy link
Member Author

Code has been updated.

Atinux
Atinux reviewed Mar 13, 2024
View reviewed changes
docs/1.guide/components.md Outdated Show resolved Hide resolved
Atinux
Atinux approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will let Pooya double check.

Thank you for helping!

pi0
pi0 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pi0 pi0 merged commit 069f2c6 into main Mar 13, 2024
3 checks passed
@pi0 pi0 deleted the feat/steps branch March 13, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atinux Atinux Atinux approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpreston321 @Atinux @pi0