feat: scanDirs respects input dirs order #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassilah
commented
Nov 15, 2022
| const result = await Promise.all( | ||
| // Do multiple glob searches to persist the order of input dirs | ||
| dirs.map(async i => await fg( | ||
| [i, ...filePatterns].map(p => join(i, p)), |
There was a problem hiding this comment.
there's a mistake here, it should be [i, ...filePatterns.map(p => join(i, p))] instead
yassilah
commented
Nov 15, 2022
| }) | ||
| .then(r => r | ||
| .map(f => normalize(f)) | ||
| .filter(fileFilter) |
There was a problem hiding this comment.
i don't think it's necessary to filter here since you're filtering after flattening the array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #141.