Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add wrapping div to prevent CopyButton from shrinking #1894

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

DeepaPrasanna
Copy link
Contributor

What does this PR do?

Fixes #1886

Before the change
Screenshot 2024-07-11 234446

After the change
Screenshot 2024-07-11 234602

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • For long permission names for example api.account.v1.AccountService.DeleteConnections, the copy button should not shrink

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 1bf0082

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 11, 2024

@DeepaPrasanna is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 6:30pm
planetfall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 6:30pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 6:30pm
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 6:30pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 6:30pm

@chronark
Copy link
Collaborator

I guess this works, any objections @guilhermerodz?

@chronark chronark enabled auto-merge July 18, 2024 17:56
@chronark chronark disabled auto-merge July 19, 2024 06:48
@chronark chronark merged commit b90a104 into unkeyed:main Jul 19, 2024
18 of 23 checks passed
@DeepaPrasanna DeepaPrasanna deleted the fix/copy-button branch July 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy Icon for permissions shrinks as permission name grows
3 participants