feat: Improve HyperlinkTableCell (#639)

unknowIfGuestInDream · Aug 4, 2023 · 43e12d4 · 43e12d4
1 parent 53abab8
commit 43e12d4
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/core/src/main/java/com/tlcsdm/core/javafx/control/HyperlinkTableCell.java b/core/src/main/java/com/tlcsdm/core/javafx/control/HyperlinkTableCell.java
@@ -11,7 +11,7 @@
 
 /**
  * Hyperlink Cell for TableView
- * 
+ *
  * @author: unknowIfGuestInDream
  * @date: 2023/8/4 13:43
  */
@@ -35,16 +35,15 @@ protected void updateItem(T item, boolean empty) {
             setText(null);
             setGraphic(null);
         } else {
-            setGraphic(hyperlink);
-            getTableRow();
-            getTableView().getItems();
-            hyperlink.setText(getTableColumn().getCellObservableValue(getIndex()).getValue().toString());
-            hyperlink.setOnAction(e -> {
-                String url = func.apply(getTableView().getItems().get(getIndex())).toString();
-                if (!url.isEmpty()) {
-                    CoreUtil.openWeb(url);
-                }
-            });
+            String url = func.apply(getTableView().getItems().get(getIndex())).toString();
+            if (!url.isEmpty()) {
+                setGraphic(hyperlink);
+                hyperlink.setText(getTableColumn().getCellObservableValue(getIndex()).getValue().toString());
+                hyperlink.setOnAction(e -> CoreUtil.openWeb(url));
+            } else {
+                setGraphic(null);
+                setText(getTableColumn().getCellObservableValue(getIndex()).getValue().toString());
+            }
         }
     }