Layout of popups broken

[squiddy]

I've had at least two instances of Popup that looked like this. The title should be moved down, the message up.

[LinuxDonald]

I will take an look on it.

[LinuxDonald]

I dont know ho to set the messange higher.

[squiddy]

Pretty sure this is caused by the label displaying the message. Look what happens when I display many lines:

Ignore for now that the <hr> is missing, still experimenting.

[squiddy]

The issue is that vertical text alignment is hardcoded to be centered here: https://github.com/fifengine/fifechan/blob/master/src/widgets/label.cpp#L134

int textY = offsetRec.y + getPaddingTop() + (getHeight() - offsetRec.height - getPaddingTop() - getPaddingBottom() - getFont()->getHeight()) / 2;

[squiddy]

See this issue to get the required functionality: fifengine/fifechan#52

[squiddy]

@LinuxDonald I fixed the size of the message labels, so the text centering is now at least consistent and doesn't look off. I'm gonna mark this issue as nice-to-have.

[squiddy]

After fixing the message label size:

[LinuxDonald]

Nice fix for now :-) now we will wait what with the fifechan ticket will happen.