VU1 EFU tests #39
Merged
VU1 EFU tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PerformV_M(name, func, CVF_INCREASING); | ||
| PerformV_M(name, func, CVF_DECREASING); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Tiny nit: generally a good idea to #undef helper defs after use, in case they cause confusion later in the file...
-[Unknown]
|
Pretty cool, seems valuable as is for sure, so I'm going to merge - can always improve later. Sorry I haven't been adding any lately, I need to get a new display that can input the signal from my PS2... -[Unknown] |
|
Thanks for the feedback. Yeah, the tests are pretty basic. I haven't seen games doing weird stuff with the EFU yet, but I'm pretty sure there's quite a few out there and I'll add more tests as I encounter them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a test that checks the behavior of all EFU functions on the VU1. Just let me know if you think I should add more test cases in there.