New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug vector send capability #118
Conversation
Thanks for putting this together @grantphllps! PRs with merge conflicts will not be reviewed nor accepted. Please resolve this issue. This is documented in the contribution guidelines. Additionally, please make the following changes to the PR summary; once these are finished, I will review the PR.
You can see an example of a PR that follows standards here |
Thank you for the notes @evan-palmer, I have resolved the merge conflicts and addressed your concerns with the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great! Thank you for putting this together. I just have a few minor change requests. Once these are resolved, it should be good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go once these issues are resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work @grantphllps. I'll finalize the CONTRIBUTING
document to reflect this change and push the release
Checklist
Changes Made
This PR implements support for sending DEBUG_VECT (MAVLINK message ID 250) messages using pymavswarm.
Associated Issues
Files Changed
pymavswarm/mavswarm.py
: Added support for sending DEBUG_VECT messages to swampymavswarm/examples/send_debug.py
: Added script that demonstrates how to send DEBUG_VECT messages to swarmTesting
Unit tests were used to confirm that added support for sending DEBUG_VECT messages can effectively build and send DEBUG_VECT messages, and that the DEBUG_VECT are received as expected.
Issues Introduced
N/A