Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug vector send capability #118

Merged
merged 15 commits into from Sep 4, 2022
Merged

Add debug vector send capability #118

merged 15 commits into from Sep 4, 2022

Conversation

grantphllps
Copy link
Collaborator

@grantphllps grantphllps commented Aug 17, 2022

Checklist

  • I have performed a thorough review of my code
  • I have sufficiently commented my code
  • The implementation follows the project style conventions
  • All project unit tests are passing
  • If necessary, documentation has been provided or updated to discuss the changes
  • System integration tests are performed successfully
  • Any new dependencies have been added to the requirements list
  • Any changes that will not be completed or bugs that have been introduced have been added as issues

Changes Made

This PR implements support for sending DEBUG_VECT (MAVLINK message ID 250) messages using pymavswarm.

Associated Issues

Files Changed

pymavswarm/mavswarm.py: Added support for sending DEBUG_VECT messages to swam
pymavswarm/examples/send_debug.py: Added script that demonstrates how to send DEBUG_VECT messages to swarm

Testing

Unit tests were used to confirm that added support for sending DEBUG_VECT messages can effectively build and send DEBUG_VECT messages, and that the DEBUG_VECT are received as expected.

Issues Introduced

N/A

@evan-palmer evan-palmer self-requested a review August 18, 2022 00:48
@evan-palmer
Copy link
Contributor

Thanks for putting this together @grantphllps! PRs with merge conflicts will not be reviewed nor accepted. Please resolve this issue. This is documented in the contribution guidelines. Additionally, please make the following changes to the PR summary; once these are finished, I will review the PR.

  1. Please use code formatting for any code-specific or related text
  2. If there is a section in the PR that is not relevant, then please just comment "N/A"
  3. In the Files Changed section, please add a summary of the changes made to each file (I see that 10 have been changed, but only one has been commented
  4. We will not accept any changes that have not been tested. I do not see any documentation that specifies the testing that has been done

You can see an example of a PR that follows standards here

@grantphllps
Copy link
Collaborator Author

Thank you for the notes @evan-palmer, I have resolved the merge conflicts and addressed your concerns with the PR.

Copy link
Contributor

@evan-palmer evan-palmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great! Thank you for putting this together. I just have a few minor change requests. Once these are resolved, it should be good to merge!

examples/send_debug.py Outdated Show resolved Hide resolved
examples/send_debug.py Outdated Show resolved Hide resolved
examples/send_debug.py Outdated Show resolved Hide resolved
pymavswarm/mavswarm.py Outdated Show resolved Hide resolved
pymavswarm/mavswarm.py Outdated Show resolved Hide resolved
pymavswarm/mavswarm.py Show resolved Hide resolved
@evan-palmer evan-palmer self-requested a review August 24, 2022 04:31
Copy link
Contributor

@evan-palmer evan-palmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go once these issues are resolved

examples/send_debug.py Outdated Show resolved Hide resolved
pymavswarm/mavswarm.py Outdated Show resolved Hide resolved
pymavswarm/mavswarm.py Outdated Show resolved Hide resolved
pymavswarm/mavswarm.py Outdated Show resolved Hide resolved
examples/send_debug.py Outdated Show resolved Hide resolved
pymavswarm/mavswarm.py Outdated Show resolved Hide resolved
@evan-palmer evan-palmer self-requested a review September 4, 2022 18:34
Copy link
Contributor

@evan-palmer evan-palmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work @grantphllps. I'll finalize the CONTRIBUTING document to reflect this change and push the release

@evan-palmer evan-palmer merged commit 905a161 into main Sep 4, 2022
@evan-palmer evan-palmer deleted the add_debug_vector branch September 4, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add debug_vector message to send_debug_message()
2 participants