Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support for specifying agent ID tuple in commands #120

Merged
merged 10 commits into from Sep 11, 2022

Conversation

evan-palmer
Copy link
Contributor

@evan-palmer evan-palmer commented Sep 3, 2022

Checklist

  • I have performed a thorough review of my code
  • I have sufficiently commented my code
  • The implementation follows the project style conventions
  • All project unit tests are passing
  • If necessary, documentation has been provided or updated to discuss the changes
  • System integration tests are performed successfully
  • Any new dependencies have been added to the requirements list
  • Any changes that will not be completed or bugs that have been introduced have been added as issues

Changes Made

This PR removes support for sending commands to a single agent by specifying the agent ID tuple. This is done for the sake of consistency and maintainability. To accomplish sending messages to a single agent, users should now wrap the agent ID tuple in a list.

Associated Issues

Closes #119

Files Changed

  • examples/*: Updated all examples to use the updated message response type
  • pymavswarm/mavswarm.py: Removed support for specifying a single agent ID tuple for message commands in favor of specifying a list

Testing

Hardware regression tests were performed by @grantphllps.

Issues Introduced

N/A

@evan-palmer evan-palmer self-assigned this Sep 3, 2022
@evan-palmer evan-palmer changed the title Removed support for specifying agent ID tuple for commands Removed support for specifying agent ID tuple in commands Sep 3, 2022
@evan-palmer evan-palmer marked this pull request as ready for review September 11, 2022 07:39
@evan-palmer evan-palmer merged commit 9022d10 into main Sep 11, 2022
@evan-palmer evan-palmer deleted the feature_119_tuple_removal branch September 11, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Remove single agent command specification in favor of list specification
1 participant