Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mission acknowledgement failure #124

Merged
merged 5 commits into from Sep 10, 2022
Merged

Fixed mission acknowledgement failure #124

merged 5 commits into from Sep 10, 2022

Conversation

evan-palmer
Copy link
Contributor

@evan-palmer evan-palmer commented Sep 4, 2022

Checklist

  • I have performed a thorough review of my code
  • I have sufficiently commented my code
  • The implementation follows the project style conventions
  • All project unit tests are passing
  • If necessary, documentation has been provided or updated to discuss the changes
  • System integration tests are performed successfully
  • Any new dependencies have been added to the requirements list
  • Any changes that will not be completed or bugs that have been introduced have been added as issues

Changes Made

This PR resolves a bug in which pymavswarm was unable to acknowledge that goto commands were received even though there was a physical response from the command.

Associated Issues

Files Changed

  • pymavswarm/mavswarm.py: Changed acknowledgement packet that the goto command should check for
  • tox.ini: Fixed envlist specification

Testing

Hardware regression tests were performed by @grantphllps (Thanks, Grant!) using the goto.py example. These tests were successful.

Issues Introduced

N/A

@evan-palmer evan-palmer self-assigned this Sep 4, 2022
@evan-palmer evan-palmer marked this pull request as ready for review September 10, 2022 00:37
@evan-palmer evan-palmer merged commit ecc0cf9 into main Sep 10, 2022
@evan-palmer evan-palmer deleted the bug_100_goto_ack branch September 10, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: goto command is not acknowledged after send
1 participant