Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More wdn-hero updates #1003

Merged
merged 8 commits into from Jun 7, 2016
Merged

More wdn-hero updates #1003

merged 8 commits into from Jun 7, 2016

Commits on May 23, 2016

  1. .wdn-hero-video video display: block 

    Same issue as #04575910

display: block removes unwanted space below the video, visibile between 768–960px
    @skoolbus39
    skoolbus39 committed May 23, 2016
    Copy the full SHA
    0e1761c View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2016

  1. Merge branch 'develop' of github.com:unl/wdntemplates into hero

    @skoolbus39
    skoolbus39 committed Jun 3, 2016
    Copy the full SHA
    f6b9eb2 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2016

  1. Apply height to hero band at bp768 

    A height declaration is needed to use object-fit on child elements.
    @skoolbus39
    skoolbus39 committed Jun 7, 2016
    Copy the full SHA
    c659340 View commit details
    Browse the repository at this point in the history

  2. Slightly reduce max-height on hero at larger widths

    @skoolbus39
    skoolbus39 committed Jun 7, 2016
    Copy the full SHA
    df15f78 View commit details
    Browse the repository at this point in the history

  3. Code formatting cleanup

    @skoolbus39
    skoolbus39 committed Jun 7, 2016
    Copy the full SHA
    ae6618f View commit details
    Browse the repository at this point in the history

  4. Enable object-fit: cover on hero video and img

    @skoolbus39
    skoolbus39 committed Jun 7, 2016
    Copy the full SHA
    c587f28 View commit details
    Browse the repository at this point in the history

  5. Move fluid hero height to object-fit conditional 

    Define explicit hero height for browsers that don't support object-fit in hopes of avoiding images or videos not filling the allotted vertical space.
    @skoolbus39
    skoolbus39 committed Jun 7, 2016
    Copy the full SHA
    a8f1f62 View commit details
    Browse the repository at this point in the history

  6. Use 'objectfit' class instead of 'object-fit' 

    'objectfit' is the [recommended usage](http://new.modernizr.com/download/#setclasses&q=object fit) by Modernizer
    @skoolbus39
    skoolbus39 committed Jun 7, 2016
    Copy the full SHA
    905755f View commit details
    Browse the repository at this point in the history