Fix home pages without home breadcrumb link lose nav on collapse #959

Merged
merged 1 commit into from Feb 11, 2016

Conversation

Projects
None yet
2 participants
@kabel
Contributor

kabel commented Feb 11, 2016

The bug fix from b042326
resolved the exception that was occurring in switchNavigation on
navigation collapse. However, it revealved that the variable reference
was not correct (after wrapInner does its magic). This caused an issue
where the active breadcurb (home navigation) could not be determined and
was removed when the navigation proxy returned a new home navigation
list.

A workaround for this issue would be to always have your home breadcrumb
be a link (as is required by the style guide).

Fix home pages without home breadcrumb link lose nav on collapse
The bug fix from b042326
resolved the exception that was occurring in switchNavigation on
navigation collapse. However, it revealved that the variable reference
was not correct (after wrapInner does its magic). This caused an issue
where the active breadcurb (home navigation) could not be determined and
was removed when the navigation proxy returned a new home navigation
list.

A workaround for this issue would be to always have your home breadcrumb
be a link (as is required by the style guide).

mfairchild365 added a commit that referenced this pull request Feb 11, 2016

Merge pull request #959 from unl/bugfix/disappearing-nav
Fix home pages without home breadcrumb link lose nav on collapse

@mfairchild365 mfairchild365 merged commit b59aae0 into develop Feb 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kabel kabel deleted the bugfix/disappearing-nav branch Feb 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment