Fix home pages without home breadcrumb link lose nav on collapse #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug fix from b042326 resolved the exception that was occurring in switchNavigation on navigation collapse. However, it revealved that the variable reference was not correct (after wrapInner does its magic). This caused an issue where the active breadcurb (home navigation) could not be determined and was removed when the navigation proxy returned a new home navigation list. A workaround for this issue would be to always have your home breadcrumb be a link (as is required by the style guide).
mfairchild365
added a commit
that referenced
this pull request
Feb 11, 2016
Fix home pages without home breadcrumb link lose nav on collapse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug fix from b042326
resolved the exception that was occurring in switchNavigation on
navigation collapse. However, it revealved that the variable reference
was not correct (after wrapInner does its magic). This caused an issue
where the active breadcurb (home navigation) could not be determined and
was removed when the navigation proxy returned a new home navigation
list.
A workaround for this issue would be to always have your home breadcrumb
be a link (as is required by the style guide).