File Manage & NavBar servicers #187
Conversation
…_name # Conflicts: # HCCGo/app/js/ConnectionService.js # HCCGo/app/js/clusterLandingCtrl.js
A few fixes discovered while testing
|
Merged your pull request and addressed the cosmetic changes. Something along these lines? |
|
Try putting the headers inside the gray area.
…-Derek
On Feb 13, 2017, at 9:37 PM, Jerrod Dixon ***@***.***> wrote:
Merged your pull request and addressed the cosmetic changes. Something along these lines?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Oh and yes, I agree! The app feels a lot more responsive now. I'm not sure on a splash screen, maybe some sort of notification of 'setting up connection' would be helpful though |
|
How about this? |
|
Yes, that looks better. 2 more things.
|
|
I made the changes requested, page looks like the following |
|
I think it looks great! I'm trying to transfer a rather large directory, with lots of directories. It seems to get stuck after creating 3 directories?
No relevant errors. |
|
My mistake, it was after a lot of directories have been completed. Possibly all of them. Now, it appears to be just sitting there. |
|
Hmm, for some reason when creating the folders it's creating a lot of folders in the top level directory instead of nested ones, with its name being where it's supposed to exist. Confused on this, as nothing of what I've changed should have affected the code in ConnectionService. Have there been any pushes to that file lately? |
|
Not sure. I don't think there's been any changes to the mkdir functions. |
|
Think I figured it out, somewhere the '/' characters are getting changed into '\' characters and so the file system takes them as parts of the file name string, not as where they're supposed to exist in the filesystem. |
|
There, give that a try |
|
Noticed a graphical oops with the progress bar, most recent commit fixes that though. |
HCCGo/app/js/ConnectionService.js
Outdated
| @@ -8,7 +8,7 @@ connectionModule.factory('connectionService',['$log', '$q', '$routeParams', '$lo | |||
| sandhills: null, | |||
| glidein: null}; | |||
| const async = require('async'); | |||
| const path = require('path'); | |||
| const path = require('path').posix; | |||
There was a problem hiding this comment.
Does this still work when you are uploading or downloading from a windows host?
|
I just tested on windows. Seems to work. Are you done with this pull request? |
|
Nearly, I tested on upload with windows and it works, but I ran into an issue retesting with download. I should have a resolution here soon |
|
That should resolve it. @djw8605 this should finalize this pull |
Control functionality for file management and navbar put in services to preserve code run state, allowing behind the scenes upload and download functionality and preventing the username from flashing on redirects.