Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to wallet on Checkout confirmation #10339

Closed
julien51 opened this issue Nov 22, 2022 · 5 comments · Fixed by #13317
Closed

Add to wallet on Checkout confirmation #10339

julien51 opened this issue Nov 22, 2022 · 5 comments · Fixed by #13317
Labels
💰bounty There's a bounty on this issue! good first issue

Comments

@julien51
Copy link
Member

julien51 commented Nov 22, 2022 •
edited
Loading

We need to add a button to "add to wallet" on the final screen in the checkout confirmation!
We already have code to add to wallet on the keychain and we could just easily re-use this code here.
@kalidiagne
Copy link
Contributor

Add button on top of "open keychain"

Screenshot 2022-11-29 at 16 44 42

@julien51 julien51 added good first issue 💰bounty There's a bounty on this issue! labels Nov 29, 2022
@ef3n9r98
Copy link

Hi @julien51, I know some devs who'd be interested in working on this. How much is the bounty for fixing this issue?

I'll put this issue up, along with the rest of the ones in the /unlock repo on OpenQ.

Thanks!

@ManyRios
Copy link
Contributor

ManyRios commented Jan 7, 2023

Still need help with this?

@SVell
Copy link
Contributor

SVell commented Feb 2, 2024

Screenshot 2024-02-02 183228
image

Errors adding NFTs even in keychain. With Rabby wallet and Metamask.

@SVell SVell mentioned this issue Feb 5, 2024
Merged
julien51 added a commit that referenced this issue Feb 13, 2024
@SVell @julien51
Resolve "Add to wallet on Checkout confirmation #10339" (#13317)
7d13276 
* Fixed Watch Asset

- Fixed watchAsset in useProvider to add ERC721 tokens
- Updated watchAsset call in keychain
- Added "Add to crypto wallet button" on checkout page after mint

* Added SVell to calbot

* Added SVell to calbot

* Removed useless import

* Created Add to Wallet dropdown

- Removed add to wallets buttons on checkout page
- Added dropdown on checkout page
- Made changes to mint.status display text

* tokenId cast to string

* Add to Wallet UI in Checkout

---------

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
@julien51
Copy link
Member Author

julien51 commented Feb 16, 2024 •
edited
Loading

Thanks @SVell

The bounty was paid! https://polygonscan.com/tx/0x55d7eec93c040af218a182de5858cbbbd1af6c94e01b5769030889b72c7da7eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💰bounty There's a bounty on this issue! good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve "Add to wallet on Checkout confirmation #10339"
5 participants
@julien51 @kalidiagne @SVell @ManyRios @ef3n9r98