Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding the Header component and its story #236

Merged
merged 1 commit into from
Sep 10, 2018
Merged

adding the Header component and its story #236

merged 1 commit into from
Sep 10, 2018

Conversation

julien51
Copy link
Member

No description provided.

@todo
Copy link

todo bot commented Sep 10, 2018

remove after we have implemented a CSS template using styled-component

https://github.com/unlock-protocol/unlock/blob/f94969a3a883798b116a9e5701d73a1ea23d6fcd/unlock-app/.storybook/head.html#L4-L9

This comment was generated by todo based on a TODO comment in f94969a3a883798b116a9e5701d73a1ea23d6fcd in #236. cc @unlock-protocol.

@julien51
Copy link
Member Author

screen shot 2018-09-10 at 17 55 56

benwerd
benwerd approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@benwerd benwerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but can we leave spare newlines at the bottom of files?

@julien51
Copy link
Member Author

@benwerd do you have a magic trick to automagically add them? Probably the linter should do that?

@julien51
Copy link
Member Author

Bim. #237
I'll rebase before merging this one ;)

@julien51 julien51 merged commit 176a877 into master Sep 10, 2018
@todo todo bot mentioned this pull request Sep 10, 2018
Closed
@julien51 julien51 deleted the creatorDashboard branch October 12, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwerd benwerd benwerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien51 @benwerd