Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using OpenZeppelin's definition of ERC721 #243

Closed
wants to merge 1 commit into from
Closed

using OpenZeppelin's definition of ERC721 #243

wants to merge 1 commit into from

Conversation

julien51
Copy link
Member

No description provided.

@todo
Copy link

todo bot commented Sep 13, 2018

We need to make this is payable because at some point we want to allow the LOCK ...

https://github.com/unlock-protocol/unlock/blob/33a9a2ec9be3a7900ba12f6c79a7b8ecd0c12b99/smart-contracts/contracts/Lock.sol#L12-L17

This comment was generated by todo based on a TODO comment in 33a9a2ec9be3a7900ba12f6c79a7b8ecd0c12b99 in #243. cc @unlock-protocol.

benwerd
benwerd approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@benwerd benwerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On rereading the Travis log, this seems to be a scripting issue rather than an actual syntax issue? If you think it's safe, go for it.

@julien51
Copy link
Member Author

Closing for now until I fix it.

@julien51 julien51 closed this Sep 19, 2018
@todo todo bot mentioned this pull request Sep 19, 2018
Closed
@julien51 julien51 deleted the erc721Zep branch October 12, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwerd benwerd benwerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien51 @benwerd