Fix for Dragonfly >=1 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might as well drop pre-v1 support at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several people have forked and removed the Dragonfly version restriction but no one has applied the proper fix to avoid loading dragonfly/rails/images so here it is. There isn't really a direct equivalent in >=1 as a little more configuration is required so let's just assume that Dragonfly has been setup correctly in recent versions.
I have also fixed the I18n translations as these didn't seem to be scoped properly.
This is my first time using this plugin and the forms look a little wonky to me but I haven't tried against older Active Admin versions so maybe it's supposed to look like that. Everything seems a little too far to the right because of the nested ol lists. At least it works. :)