Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: IDEA eslint compatibility #1567

Merged
merged 1 commit into from
Sep 12, 2022
Merged

chore: IDEA eslint compatibility #1567

merged 1 commit into from
Sep 12, 2022

Conversation

sudongyuer
Copy link
Member

@netlify
Copy link

netlify bot commented Sep 7, 2022 •
edited

✅ Deploy Preview for unocss canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c0a4c18
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6318bb4dc3e6df00084e3592

@sudongyuer sudongyuer changed the title fix(eslint): eslint idea compatibility fix(eslint): eslint IDEA compatibility Sep 7, 2022
@sudongyuer sudongyuer changed the title fix(eslint): eslint IDEA compatibility fix(eslint): Eslint IDEA compatibility Sep 7, 2022
@sudongyuer sudongyuer changed the title fix(eslint): Eslint IDEA compatibility fix(eslint): eslint idea compatibility Sep 7, 2022
@antfu
Copy link
Member

antfu commented Sep 10, 2022

I am not sure. I think it's better to have IDEA fix it instead of reverting the version on our side

@userquin
Copy link
Member

userquin commented Sep 10, 2022 •
edited

@antfu will be fixed in 2022.2.3 so there is no need to update here: https://youtrack.jetbrains.com/issue/WEB-57089

EDIT: it is 2 versions from current, this will take time... and it is a bad experience since we lose dx

@sudongyuer
Copy link
Member Author

@antfu will be fixed in 2022.2.3 so there is no need to update here: https://youtrack.jetbrains.com/issue/WEB-57089

EDIT: it is 2 versions from current, this will take time... and it is a bad experience since we lose dx

+1

@antfu antfu changed the title fix(eslint): eslint idea compatibility chore: IDEA eslint compatibility Sep 12, 2022
@antfu antfu merged commit 1572e6e into unocss:main Sep 12, 2022
@userquin
Copy link
Member

@antfu IntelliJ 2022.2.2 released and seems the error is gone, so we can revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu antfu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sudongyuer @antfu @userquin