Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer-attributify-jsx): skip curlybrace expression #1867

merged 3 commits into from Nov 12, 2022


Copy link

@liou666 liou666 commented Nov 10, 2022

fix #1866

@liou666 liou666 requested a review from antfu as a code owner November 10, 2022 09:25
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2fb7b91
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sudongyuer sudongyuer changed the title fix: skip attr with curlybrace expression fix(transformer-attributify-jsx): skip curlybrace expression Nov 10, 2022
@antfu antfu merged commit f2cef8d into unocss:main Nov 12, 2022
Copy link

chaozwn commented Nov 14, 2022

i found a bug in this commit.

<a href="#" p-3 key={index}>友情链接</a>

in this case , const curlybraceRE = /\{.+\}/g; This skip will cause p-3 to lose the change to p-3=""

praburangki pushed a commit to praburangki/unocss that referenced this pull request Jan 12, 2023

Co-authored-by: liuxinqi <>
Co-authored-by: Frozen FIsh <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

bug: The transformer-attributify-jsx does not work correctly
4 participants