Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): svelte-scoped: search attributify candidates only on template #2287

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Mar 1, 2023

Fixes #2284

Is transforming node_modules in svelte-scoped mode something we expected?

@sibbng sibbng requested a review from antfu as a code owner March 1, 2023 14:10
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 1c05b02
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63ff5cd4e52ebc0009c45afb
😎 Deploy Preview https://deploy-preview-2287--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu changed the title fix(vite): search attributify candidates only on template in svelte scoped mode fix(vite): svelte-scoped: search attributify candidates only on template Mar 1, 2023
@antfu
Copy link
Member

antfu commented Mar 1, 2023

Is transforming node_modules in svelte-scoped mode something we expected?

Yes I think so. It will be able to support unbundled components libs. Users can always manually exclude if they don't want it, but the other way around would make things harder to config.

@antfu antfu merged commit 9af4936 into main Mar 1, 2023
@antfu antfu deleted the fix/svelte-scoped-attributify branch March 1, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteKit application doesn't build after updating uno from 0.50.1 to 0.50.2
2 participants