Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-mini): support border-stuff #257

Merged
merged 4 commits into from Dec 11, 2021
Merged

Conversation

chu121su12
Copy link
Collaborator

Together with #256, attempt to close #178.
/cc @userquin

@netlify
Copy link

netlify bot commented Dec 11, 2021

✔️ Deploy Preview for ecstatic-mestorf-2e8afd ready!

🔨 Explore the source changes: d98c284

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-mestorf-2e8afd/deploys/61b4dde71a6b190007671d0a

😎 Browse the preview: https://deploy-preview-257--ecstatic-mestorf-2e8afd.netlify.app

@userquin
Copy link
Member

userquin commented Dec 11, 2021

@chu121su12 there are duplicate rules for border and border size, cannot be compacted using for example handleBorderOrBorderColor?

  // size
  [/^(?:border|b)()-(.+)$/, handlerBorder],
  [/^(?:border|b)-([^-]+)-(.+)$/, handlerBorder],

  // colors
  [/^(?:border|b)()-(.+)$/, handlerBorderColor],
  [/^(?:border|b)-([^-]+)-(.+)$/, handlerBorderColor],

@antfu antfu merged commit 5f3e85e into unocss:main Dec 11, 2021
@chu121su12
Copy link
Collaborator Author

@chu121su12 there are duplicate rules for border and border size, cannot be compacted using for example handleBorderOrBorderColor?

@userquin I saw that too, and there's similar situation in text-<color> and text-<size>. I may try to refactor those later.

@chu121su12 chu121su12 deleted the border-stuff branch December 11, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(preset-uno): border stuff
3 participants