fix(astro): inject duplicate style #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
requested changes
May 9, 2023
antfu
reviewed
May 15, 2023
packages/astro/src/index.ts
Outdated
| import type { Plugin } from 'vite' | ||
|
|
||
| const UNO_INJECT_ID = 'uno-astro' | ||
| const UNO_QUERY_KEY = 'uwa' |
There was a problem hiding this comment.
What does uwa mean? Can we use a longer and more descriptive name?
There was a problem hiding this comment.
I used uno-with-astro-key instead of uwa, do you think that would work?
Also, the UNO_QUERY_KEY will be displayed on the url
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2513
Avoid inject styles in non-ssr