Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): correctly output CSS string #3686

Merged
merged 1 commit into from Apr 5, 2024
Merged

Conversation

lzl0304
Copy link
Contributor

@lzl0304 lzl0304 commented Apr 3, 2024

fix: #3652

Repeated calls to the getCssEscaperForJsContent function result in multiple escapes of special characters, leading to errors when Webpack invokes the eval function.

The incorrect output is:
.after\\\:content-empty::after{content:\\"\\";}

And the correct output should be:
.after\:content-empty::after{content:\"\";}

@lzl0304 lzl0304 requested a review from antfu as a code owner April 3, 2024 10:28
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a44653d
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/660d2f671235490008dd420a
😎 Deploy Preview https://deploy-preview-3686--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu merged commit a03c25c into unocss:main Apr 5, 2024
9 checks passed
@lzl0304 lzl0304 deleted the fix-3652 branch April 18, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: webpack 5 using style-loader
2 participants