Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): skip the root uno.config when merging #3886

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

enkot
Copy link
Contributor

@enkot enkot commented Jun 11, 2024

Related #3837

#3838 added logic to merge ALL uno.configs from Nuxt layers and generate ./.nuxt/uno.config.mjs.

Problem:
Because Eslint, VSCode plugins and other tools rely on uno.config file, we need to tell them to look for the new location(./.nuxt). While this can be done for Eslint (settings->unocss->configPath), implementing a new option for VSCode, JetBrains etc. will kill DX.

This PR skips the root uno.config file when merging configs from Nuxt layers, so user should manually reexport merged config from ./.nuxt/uno.config.mjs and other tools will work as usual:

// uno.config.ts
import config from './.nuxt/uno.config.mjs'

export default config

@enkot enkot requested a review from antfu as a code owner June 11, 2024 22:10
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8b4f674
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6668cb54d5cc4d00088d2798
😎 Deploy Preview https://deploy-preview-3886--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu added this pull request to the merge queue Jun 12, 2024
Merged via the queue into unocss:main with commit faa3006 Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants