Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(variantGroup): nested variantGroup #831

Merged
merged 1 commit into from Apr 17, 2022

Conversation

zojize
Copy link
Contributor

@zojize zojize commented Apr 16, 2022

Features

  • Brute force implementation for variant groups and tests

image

- extract quoted content from js/ts/vue files

Fixes

Before this PR, it is possible for the variant group transformer to mistakenly transform valid js code:
image

Although I doubt anyone would write code this way, this is undesirable behavior and may lead to vulnerability in production code. To address this, I implemented a simple extractor to extract only quoted content from files. and here's the result

image

@zojize zojize requested a review from antfu as a code owner April 16, 2022 06:57
@netlify
Copy link

netlify bot commented Apr 16, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit db97240
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/625a68e8f515500008e7d19f
😎 Deploy Preview https://deploy-preview-831--unocss.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants