fix: Add more uap targets to avoid System.Runtime.InteropServices.WindowsRuntime mismatches in desktop packaging
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndowsRuntime` mismatches in desktop packaging
jeromelaban
force-pushed
the
dev/jela/uap-updates
branch
from
b987ecd
to
b99f947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): fixes unoplatform/uno#6065
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Packaging an UWP application with a min version not matching the uap10.0 generic target defined by msbuild extras causes issues with the assembly loader (such as this one https://stackoverflow.com/questions/48211211/uwp-application-could-not-load-file-or-assembly-system-runtime-windowsruntime).
This change adds more explicit targets to avoid mismatches.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):