Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ControlLibrary Sample - Update to net6 #253

Closed

Conversation

aesteves900
Copy link
Contributor

No description provided.

@aesteves900 aesteves900 marked this pull request as ready for review November 30, 2022 18:36
@aesteves900 aesteves900 self-assigned this Dec 1, 2022
@nickrandolph
Copy link
Collaborator

nickrandolph commented Jan 2, 2023

@aesteves900 a couple of points:

  • This sample is supposed to demonstrate referencing a templated control from a referenced control library (see #MyTemplatedControl that's contained within the XamlControlLibrary project. Don't just include MyTemplatedControl in the shared project
  • The sample is missing some of the uno targets (eg wpf, gtk, linux). Make sure the sample includes all uno targets
  • It looks like the Wasm and Android targets (and probably others) aren't rendering the custom control. Can you please make sure you test the samples on all platforms. This issue is probably related to the first point - if you restructure the code as per the original sample, this should fix this issue.

@nickrandolph nickrandolph marked this pull request as draft January 2, 2023 01:47
@aesteves900
Copy link
Contributor Author

Hello @nickrandolph

  • Okay I will fix that
  • Could we create an issue for that? According to Jerome we need to update each sample as-is.
  • I fixing the issue, because the control rendering on Windows properly.

@aesteves900 aesteves900 marked this pull request as ready for review February 17, 2023 15:20
@nickrandolph nickrandolph mentioned this pull request Jul 17, 2023
16 tasks
@nickrandolph
Copy link
Collaborator

Closing this as this sample has already been updated now

@nickrandolph nickrandolph deleted the dev/AEST/190-update-to-net6-controllibrary branch September 4, 2023 10:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants