-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: adjust brushes opacities #1261
Conversation
DisableLow
is now changed to Disabled in the docs
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename commit to:
fix!: adjust brushes opacities
358c42b
to
90541d2
Compare
@Xiaoy312 I did checked the commit message accordingly. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
9d2f897
to
f022a6b
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
2 similar comments
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1261.eastus2.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on @NVLudwig's confirmation for the opacities values before we can merge this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should change the value of DisabledLowOpacity instead of referring to DisabledOpacity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also if said value was changed (or just with current change in this file), there is no need to update [button,fab,nav-view,pbox].xaml since the disabled-low brushes will have the same value as disabled brushes
| `LowOpacity` | 0.32 | | ||
| `DisabledOpacity` | 0.38 | | ||
| `DisabledLowOpacity` | 0.12 | | ||
| Key | Value | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Headings should be surrounded by blank lines
| Key | Value | | |
| Key | Value | |
to be replaced by #1369 |
Closing this PR as the changes were done in #1369 |
GitHub Issue: close #1236
PR Type
What kind of change does this PR introduce?
Description
Replacing the DisabledLow opacity with Disabled
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):