Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RatingControl)!: adjust ratingcontrol resource keys #1350

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

kazo0
Copy link
Collaborator

@kazo0 kazo0 commented Feb 7, 2024

BREAKING CHANGE: RatingControl Lightweight Styling keys have changed to align the WinUI resource keys

closes #1349

PR Type

What kind of change does this PR introduce?

  • Bugfix

Current Behavior

Given the following XAML:

<Grid VerticalAlignment="Center">
    <Grid.RowDefinitions>
        <RowDefinition Height="Auto" />
        <RowDefinition Height="Auto" />
    </Grid.RowDefinitions>
    <RatingControl VerticalAlignment="Center"
                    HorizontalAlignment="Center"
                    Value="3">
        <RatingControl.Resources>
            <SolidColorBrush x:Key="RatingControlSelectedForeground"
                                Color="Red" />
            <SolidColorBrush x:Key="RatingControlUnselectedForeground"
                                Color="Orange" />
        </RatingControl.Resources>
    </RatingControl>
    <Border Grid.Row="1">
        <Border.Resources>
            <MaterialTheme xmlns="using:Uno.Material" />
        </Border.Resources>
        <RatingControl VerticalAlignment="Center"
                        HorizontalAlignment="Center"
                        Value="3">
            <RatingControl.Resources>
                <SolidColorBrush x:Key="RatingControlSelectedForeground"
                                    Color="Red" />
                <SolidColorBrush x:Key="RatingControlUnselectedForeground"
                                    Color="Orange" />
            </RatingControl.Resources>
        </RatingControl>
    </Border>
</Grid>

image

New Behavior

image

BREAKING CHANGE: RatingControl Lightweight Styling keys have changed to align the WinUI resoure keys
@kazo0 kazo0 enabled auto-merge (squash) February 7, 2024 17:29
@kazo0 kazo0 merged commit 24d80ff into master Feb 7, 2024
13 checks passed
@kazo0 kazo0 deleted the dev/sb/ratingcontrol branch February 7, 2024 18:39
@kazo0
Copy link
Collaborator Author

kazo0 commented Feb 7, 2024

@Mergifyio backport stable/release/4.1

Copy link

mergify bot commented Feb 7, 2024

backport stable/release/4.1

❌ No backport have been created

  • Backport to branch stable/release/4.1 failed

GitHub error: Branch not found

@kazo0
Copy link
Collaborator Author

kazo0 commented Feb 8, 2024

@Mergifyio backport release/stable/4.1

Copy link

mergify bot commented Feb 8, 2024

backport release/stable/4.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 8, 2024
BREAKING CHANGE: RatingControl Lightweight Styling keys have changed to align the WinUI resoure keys

(cherry picked from commit 24d80ff)

# Conflicts:
#	doc/material-migration.md
kazo0 added a commit that referenced this pull request Feb 13, 2024
…) (#1352)

* fix(RatingControl)!: adjust ratingcontrol resource keys (#1350)

BREAKING CHANGE: RatingControl Lightweight Styling keys have changed to align the WinUI resoure keys

(cherry picked from commit 24d80ff)

# Conflicts:
#	doc/material-migration.md

* chore: fix conflicts

---------

Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RatingControl Lightweight Styling not working for RatingControlSelectedForeground
2 participants