feat: adding maui-core fix resource paths #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
approved these changes
Aug 16, 2023
dansiegel
force-pushed
the
dev/ds/maui-core
branch
from
b5d9f3d
to
7b2a590
Compare
nickrandolph
force-pushed
the
dev/ds/maui-core
branch
from
7ebc6dc
to
0ebfd1a
Compare
|
@mergify backport legacy/2x |
✅ Backports have been created
|
nickrandolph
added a commit
that referenced
this pull request
Aug 22, 2023
feat: adding maui-core fix resource paths (backport #1784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Assets are broken. You must reference the Resource extension from the Core project. References to
Microsoft.Maui.Controls.Application.Current.MainPagewill fail.What is the new behavior?
Introduces new Maui Core package which contains the extension for injecting styles.
Adds props file to disable Msix on the non-head projects (this fixes resource paths)
Initializes the Microsoft.Maui.Controls.Application with a Page (this enables scenarios where Display Alert may be called)