Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding maui-core fix resource paths (backport #1784) #1788

Merged
merged 27 commits into from
Aug 22, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 18, 2023

This is an automatic backport of pull request #1784 done by Mergify.
Cherry-pick of 701473a has failed:

On branch mergify/bp/legacy/2x/pr-1784
Your branch is ahead of 'origin/legacy/2x' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 701473ad.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    samples/MauiEmbedding/MauiEmbedding.Skia.Gtk/Package.appxmanifest
	deleted:    samples/MauiEmbedding/MauiEmbedding.Skia.Gtk/app.manifest
	deleted:    samples/MauiEmbedding/MauiEmbedding.Wasm/LinkerConfig.xml
	deleted:    samples/MauiEmbedding/MauiEmbedding.Wasm/Program.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding.Wasm/WasmCSS/Fonts.css
	deleted:    samples/MauiEmbedding/MauiEmbedding.Wasm/WasmScripts/AppManifest.js
	deleted:    samples/MauiEmbedding/MauiEmbedding.Wasm/manifest.webmanifest
	deleted:    samples/MauiEmbedding/MauiEmbedding.Wasm/wwwroot/staticwebapp.config.json
	deleted:    samples/MauiEmbedding/MauiEmbedding.Wasm/wwwroot/web.config

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: samples/MauiEmbedding/MauiEmbedding.Skia.Gtk/MauiEmbedding.Skia.Gtk.csproj
	deleted by them: samples/MauiEmbedding/MauiEmbedding.Skia.Gtk/Program.cs
	deleted by them: samples/MauiEmbedding/MauiEmbedding.Wasm/MauiEmbedding.Wasm.csproj
	both modified:   samples/MauiEmbedding/MauiEmbedding.sln

Cherry-pick of 392d293 has failed:

On branch mergify/bp/legacy/2x/pr-1784
Your branch is ahead of 'origin/legacy/2x' by 3 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 392d293c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    src/Uno.Extensions.Maui.Core/MauiEmbeddingCoreExtensions.cs
	deleted:    src/Uno.Extensions.Maui.Core/MauiResourceProvider.cs
	deleted:    src/Uno.Extensions.Maui.Core/build/Package.props
	new file:   src/Uno.Extensions.Maui.UI/Internals/EmbeddingApp.cs
	modified:   src/Uno.Extensions.Maui.UI/MauiEmbedding.cs
	modified:   src/Uno.Extensions.Maui.UI/MauiHost.cs
	modified:   src/Uno.Extensions.Maui.UI/Uno.Extensions.Maui.WinUI.csproj
	modified:   src/Uno.Extensions.Maui.UI/build/Package.props
	modified:   src/Uno.Extensions.sln

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   samples/MauiEmbedding/MauiEmbedding.sln

Cherry-pick of 0ebfd1a has failed:

On branch mergify/bp/legacy/2x/pr-1784
Your branch is ahead of 'origin/legacy/2x' by 6 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 0ebfd1a9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   samples/MauiEmbedding/MauiEmbedding/App.cs
	modified:   samples/MauiEmbedding/MauiEmbedding/MauiEmbedding.csproj
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/EsriMapsPage.xaml
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/EsriMapsPage.xaml.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/EsriMapsViewModel.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/ExternalLibPage.xaml
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/ExternalLibPage.xaml.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/ExternalLibViewModel.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MCTControlsPage.xaml
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MCTControlsPage.xaml.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MCTControlsViewModel.cs
	modified:   samples/MauiEmbedding/MauiEmbedding/Presentation/MainPage.xaml
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiColorsPage.xaml.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiColorsViewModel.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiControlsPage.xaml
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiControlsPage.xaml.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiControlsViewModel.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiEssentialsPage.xaml
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiEssentialsPage.xaml.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/MauiEssentialsViewModel.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/TelerikControlsPage.xaml
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/TelerikControlsPage.xaml.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/TelerikControlsViewModel.cs
	deleted:    samples/MauiEmbedding/MauiEmbedding/Presentation/TitleConverter.cs
	new file:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/App.xaml
	new file:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/App.xaml.cs
	modified:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/AppBuildExtensions.cs
	new file:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/EmbeddedControl.xaml
	new file:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/EmbeddedControl.xaml.cs
	modified:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/MauiControlsExternal.csproj
	new file:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/Styles/Colors.xaml
	new file:   samples/MauiEmbedding/MauiProjects/MauiControlsExternal/Styles/Styles.xaml
	modified:   src/Uno.Extensions.Maui.UI/MauiHost.cs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: samples/MauiEmbedding/MauiEmbedding/Presentation/MauiColorsPage.xaml

Cherry-pick of e9ad8c4 has failed:

On branch mergify/bp/legacy/2x/pr-1784
Your branch is ahead of 'origin/legacy/2x' by 7 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit e9ad8c42.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   build/ci/.azure-pipelines.Packages.yml
	modified:   build/ci/.azure-pipelines.Windows.yml
	deleted:    src/Uno.Extensions.Maui.Core/Uno.Extensions.Maui.Core.csproj

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   build/ci/.azure-pipelines.yml
	both modified:   src/Uno.Extensions-packageonly.slnf

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

dansiegel and others added 12 commits August 18, 2023 09:09
(cherry picked from commit 701473a)

# Conflicts:
#	samples/MauiEmbedding/MauiEmbedding.Skia.Gtk/MauiEmbedding.Skia.Gtk.csproj
#	samples/MauiEmbedding/MauiEmbedding.Skia.Gtk/Program.cs
#	samples/MauiEmbedding/MauiEmbedding.Wasm/MauiEmbedding.Wasm.csproj
#	samples/MauiEmbedding/MauiEmbedding.sln
(cherry picked from commit 392d293)

# Conflicts:
#	samples/MauiEmbedding/MauiEmbedding.sln
(cherry picked from commit 7b2a590)
(cherry picked from commit 0ebfd1a)

# Conflicts:
#	samples/MauiEmbedding/MauiEmbedding/Presentation/MauiColorsPage.xaml
(cherry picked from commit e9ad8c4)

# Conflicts:
#	build/ci/.azure-pipelines.yml
#	src/Uno.Extensions-packageonly.slnf
(cherry picked from commit 395c14a)
(cherry picked from commit b5aea27)
(cherry picked from commit dfb5a97)
(cherry picked from commit d3de6a9)
@nickrandolph
Copy link
Contributor

nickrandolph commented Aug 22, 2023

Added backport for #1787

@nickrandolph
Copy link
Contributor

Added backport of #1789

@nickrandolph nickrandolph merged commit e79fd8d into legacy/2x Aug 22, 2023
11 checks passed
@nickrandolph nickrandolph deleted the mergify/bp/legacy/2x/pr-1784 branch August 22, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants