Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove pre-net6 (and commerce) template #565

Merged
merged 2 commits into from
Jun 30, 2022
Merged

feat: Remove pre-net6 (and commerce) template #565

merged 2 commits into from
Jun 30, 2022

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Jun 28, 2022 •
edited
Loading

(conditional on #564)

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the new behavior?

  • Remove pre-net6 extensions template
  • Remove commerce template
  • Update net6 template to use single Windows project and single WPF project

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as ready for review June 29, 2022 01:35
@nickrandolph nickrandolph requested a review from a team June 29, 2022 01:35
@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

@nickrandolph nickrandolph force-pushed the dev/nr/unoextauthtemplate branch 2 times, most recently from 66356a6 to 4f55392 Compare June 29, 2022 04:53
@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

@nickrandolph
Copy link
Contributor Author

@jeromelaban would you be able to double check the updates to the unoapp-extensions template - let me know if there's any other updates we need to do to bring it inline with the updated unoapp template

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-565.eastus2.azurestaticapps.net

@nickrandolph nickrandolph merged commit 071acd0 into main Jun 30, 2022
@nickrandolph nickrandolph deleted the dev/nr/unoextauthtemplate branch June 30, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrandolph @jeromelaban