Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add app.manifest to Windows targets #44

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Apr 5, 2023

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

app.manifest is not properly used, which means the app don't adhere to DPI scaling changes (and fractional scaling)

What is the new behavior?

  • Add <ApplicationManifest> to all Windows targets
  • Update app.manifest as per latest WinUI project template

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@dansiegel dansiegel merged commit f3a6436 into main Apr 5, 2023
@dansiegel dansiegel deleted the dev/mazi/app-manifests branch April 5, 2023 12:08
@welcome
Copy link

welcome bot commented Apr 5, 2023

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants