Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cutted text with content only long text #1017

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

Arieldelossantos
Copy link
Contributor

@Arieldelossantos Arieldelossantos commented Jan 29, 2024

closes #1039

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

with content only tabBar item, if the text is too long, it is cutted off.

What is the new behavior?

support larger text with may tabs created.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

https://github.com/unoplatform/uno.chefs/issues/937

@Arieldelossantos
Copy link
Contributor Author

this is an updated branch for the textTrimming issue, for some reason the git index was broken on my side and wasn't updating the other PR branch...

@kazo0 i've added the TextTrimming prop, but it's is still cutting the text if is too long... could this be related to another issue, maybe the container not clipping properly the content? any other idea?

@kazo0
Copy link
Contributor

kazo0 commented Jan 29, 2024

I'm not sure there's too much we can do if the text is too long, if there's no room for the text at a certain point it's going to have to get cut

@Arieldelossantos do you have screenshots of what it looks like when its still getting cut?

@Arieldelossantos
Copy link
Contributor Author

Arieldelossantos commented Jan 29, 2024

but the thing is that it's not adding the ellipsis on the cutted character :/

there's an error on the runtime test on Sample that is blocking me to deploy Android... i think it was introduced on latest main, because i've rebased the branch...
but for this test"ingridients123456789" it will display "ingridients1" with 4 tabs created
@kazo0

@kazo0
Copy link
Contributor

kazo0 commented Jan 29, 2024

@Arieldelossantos ah I believe these TextTrimming property doesn't exist for ContentPresenter? So I'm not sure if there is too much we can do here

@kazo0 kazo0 force-pushed the Dev/arde/fix-tabbar-content-cutted-text branch from 916ec76 to 75050de Compare February 13, 2024 20:08
@kazo0 kazo0 marked this pull request as draft February 13, 2024 20:08
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net

@kazo0 kazo0 force-pushed the Dev/arde/fix-tabbar-content-cutted-text branch from ea5c537 to c15a319 Compare February 13, 2024 20:27
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net

@kazo0 kazo0 marked this pull request as ready for review February 13, 2024 23:57
@kazo0 kazo0 enabled auto-merge (squash) February 14, 2024 01:08
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1017.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 5528d3a into main Feb 14, 2024
26 checks passed
@kazo0 kazo0 deleted the Dev/arde/fix-tabbar-content-cutted-text branch February 14, 2024 03:30
@kazo0
Copy link
Contributor

kazo0 commented Feb 14, 2024

@Mergifyio backport release/stable/5.1

Copy link
Contributor

mergify bot commented Feb 14, 2024

backport release/stable/5.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 14, 2024
* fix: cutted text with content only long text

* fix: font bindings

---------

Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
(cherry picked from commit 5528d3a)
kazo0 pushed a commit that referenced this pull request Feb 14, 2024
* fix: cutted text with content only long text

* fix: font bindings

---------

Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
(cherry picked from commit 5528d3a)

Co-authored-by: Ariel De Los Santos <ariel.delossantos@nventive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TopTabBar Cropping Labels and different font weight
2 participants