Prevent AutoLayout from causing an invalidation loop on WinUI #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould go into an invalidation loop. fixes #1131
kazo0
reviewed
May 16, 2024
kazo0
approved these changes
May 16, 2024
|
@Mergifyio backport release/stable/6.0 |
✅ Backports have been created
|
19 tasks
jeromelaban
added a commit
that referenced
this pull request
May 17, 2024
….0/pr-1138 Prevent AutoLayout from causing an invalidation loop on WinUI (backport #1138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1131
Bugfix
What is the current behavior?
In some situations, it was possible to crash the UI in WinUI, launching an invalidation loop.
What is the new behavior?
Now works properly on both WinUI and Uno. Child elements are not remeasured during arrange phase, we're just using their desired size to layout them.
PR Checklist
Please check if your PR fulfills the following requirements: