Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TabBar): Vertical TabBar #434

Merged
merged 5 commits into from
Jan 12, 2023
Merged

feat(TabBar): Vertical TabBar #434

merged 5 commits into from
Jan 12, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Dec 20, 2022 •
edited
Loading

closes #278
related bug: unoplatform/uno#10786
https://github.com/unoplatform/uno.chefs/issues/125

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

No vertical TabBar

What is the new behavior?

Vertical TabBar exists

image

image

image

@kazo0
Copy link
Contributor Author

kazo0 commented Dec 20, 2022

/cc @carldebilly, @NVLudwig

@github-actions
Copy link

github-actions bot commented Dec 20, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-434.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Dec 21, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-434.eastus2.azurestaticapps.net

@kazo0 kazo0 mentioned this pull request Dec 22, 2022
Closed
@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Dec 22, 2022 •
edited
Loading

you can explain a bit how was unoplatform/uno#10786 addressed?
btw you need to prefix closing keywords before each linked issue in order to chain closing them with this pr.

@kazo0
Copy link
Contributor Author

kazo0 commented Jan 11, 2023 •
edited
Loading

you can explain a bit how was unoplatform/uno#10786 addressed? btw you need to prefix closing keywords before each linked issue in order to chain closing them with this pr.

@Xiaoy312 it is mentioned here in the xaml

The bug wasn't addressed, I was just linking to it as we have to use a workaround

@github-actions
Copy link

github-actions bot commented Jan 11, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-434.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) January 11, 2023 21:47
@kazo0 kazo0 disabled auto-merge January 11, 2023 23:27
@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-434.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-434.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit e4a94ae into main Jan 12, 2023
@kazo0 kazo0 deleted the dev/sb/vertical-tabbar branch January 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vertical TabBar support
3 participants
@kazo0 @Xiaoy312 @carldebilly