Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery][Android]TabBar(Material)- "only" Text for the 'Content only' Tab and "Right" Icon for 'Tab with Icon' Tab are truncating for TabBar items. #8228

Closed
sakshi173 opened this issue Mar 3, 2022 · 6 comments · Fixed by unoplatform/uno.toolkit.ui#197 or unoplatform/uno.toolkit.ui#598
Assignees
Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery triage/untriaged Indicates an issue requires triaging or verification

Comments

@sakshi173
Copy link

sakshi173 commented Mar 3, 2022

Current behavior

Only text truncate issue new

Expected behavior

right icon and 'Content only' text should not get truncate.
only text correct

How to reproduce it (as minimally and precisely as possible)

  1. Open Uno Gallery APP .
  2. Click/tap Burger Menu on the left top right.
  3. Ensure that the Gallery app is in Day Mode.
  4. Tap "TabBar" from the "Toolkit" list.
  5. Go to 'Material' section.
  6. Go to 'Adding Items as TabBarItems directly' section.
  7. Observe that 'Right Icon' is truncating for 'Tab with Icon' Tab and 'Only' text is truncating at the end for the 'Content Only' tab.

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

No response

Affected platforms

Android

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@sakshi173 sakshi173 added kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform triage/untriaged Indicates an issue requires triaging or verification area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Mar 3, 2022
@kazo0 kazo0 self-assigned this Mar 4, 2022
@sakshi173 sakshi173 changed the title [Gallery][Android]TabBar(Material)- Text is truncating in the end for 'Content only' Tab for 'TabBarItems directly' section. [Gallery][Android]TabBar(Material)- 'Only' Text for the 'Content only' Tab and 'Right' Icon for 'Tab with Icon' Tab are truncating present for 'TabBarItems directly' section. Mar 4, 2022
@sakshi173 sakshi173 changed the title [Gallery][Android]TabBar(Material)- 'Only' Text for the 'Content only' Tab and 'Right' Icon for 'Tab with Icon' Tab are truncating present for 'TabBarItems directly' section. [Gallery][Android]TabBar(Material)- "only" Text for the 'Content only' Tab and "Right" Icon for 'Tab with Icon' Tab are truncating for TabBar items. Mar 4, 2022
@sakshi173
Copy link
Author

Bug is not fixed, Verified in the latest canary build, Due to that reopening it.
Version 1.5.0 (400898) ,Mar 22, 2022 at 22:36, Canary a339922fe42f1a09ff9a02a3495b2528e8454422
tabbar issue 2

@sakshi173 sakshi173 reopened this Mar 23, 2022
@sakshi173 sakshi173 added the project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery label Jul 19, 2022
@kazo0
Copy link
Contributor

kazo0 commented Dec 22, 2022

@sakshi173 is this still an issue with the latest canaries?

@sakshi173
Copy link
Author

@kazo0, I check it and let you know. Thanks!!

@sakshi173
Copy link
Author

@kazo0, I checked the issue is still present. and also there is another new bug --- Home Icon is not displaying correctly for all platform. I am raising it separately.

@kazo0
Copy link
Contributor

kazo0 commented Dec 22, 2022

@sakshi173 thanks!

Yeah the Home icon will be fixed when this merges unoplatform/uno.toolkit.ui#434

@kazo0 kazo0 removed their assignment Jun 2, 2023
@lesterbotello lesterbotello self-assigned this Jun 2, 2023
@lesterbotello
Copy link

lesterbotello commented Jun 2, 2023

Hey @kazo0 @sakshi173, this is also reproducible on iOS with a small enough device (i.e. iPhone SE), so it seems truncation is a byproduct of reduced screen space. The question here is, what would be the expected behavior when there's not enough space to fit both the image and the text? I know the issue specifies "text should not truncate", but in a small factor device, there's no really a way to avoid it.

Would cutting the text and adding ellipses at the end of the remaining text would be enough? (i.e. "Content o...")

EDIT: Typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
3 participants