Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure NavBar closes Popup regardless of being within a Page #466

Merged
merged 2 commits into from
Feb 8, 2023
Merged

fix: Ensure NavBar closes Popup regardless of being within a Page #466

merged 2 commits into from
Feb 8, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Feb 1, 2023 •
edited
Loading

closes https://github.com/unoplatform/uno.chefs/issues/257

  • Closing Popup on Back when NavigationBar is inside the Popup

@kazo0 kazo0 marked this pull request as draft February 1, 2023 21:42
@github-actions
Copy link

github-actions bot commented Feb 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@kazo0 kazo0 marked this pull request as ready for review February 2, 2023 04:05
@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

4 similar comments
@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

agneszitte
agneszitte reviewed Feb 2, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will wait for @nickrandolph's review also

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@agneszitte agneszitte mentioned this pull request Feb 2, 2023
Merged
7 tasks
@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

7 similar comments
@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor Author

kazo0 commented Feb 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

github-actions bot commented Feb 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

20 similar comments
@github-actions
Copy link

github-actions bot commented Feb 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@mergify mergify bot mentioned this pull request Feb 6, 2023
Merged
@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-466.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 5d70c5f into main Feb 8, 2023
@kazo0 kazo0 deleted the dev/sb/navbar-popup branch February 8, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kazo0 @agneszitte