Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TabBar Selection Indicator adapts to collapsed items #491

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Mar 3, 2023

closes #495

TabBarSelectionIndicatorPresenter needs to change MaxSize of the indicator when items in the list are Visibility.Collapsed

PR Type

What kind of change does this PR introduce?

  • Bugfix

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Mar 8, 2023

i felt like one day, we will run into problem with two XyzExtensions classes (xaml attached property vs c# extensions method) in the same namespace
while we could make them both static partial, it kinda felt wrong

@kazo0 kazo0 marked this pull request as draft March 8, 2023 15:54
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@kazo0 kazo0 marked this pull request as ready for review March 9, 2023 18:15
@kazo0 kazo0 force-pushed the dev/sb/tab-bar-indicator-vis branch from 3484a7b to 30d7487 Compare March 9, 2023 19:44
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@kazo0 kazo0 force-pushed the dev/sb/tab-bar-indicator-vis branch from e82c2b2 to 4370de8 Compare March 9, 2023 20:58
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) March 9, 2023 21:02
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor Author

kazo0 commented Mar 10, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-491.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit ac7adc4 into main Mar 10, 2023
@kazo0 kazo0 deleted the dev/sb/tab-bar-indicator-vis branch March 10, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION] TabBars are not selectable/broken when multiple TabBars are used on multiple Pages
3 participants