-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DisableAnimations to UseTransitions #554
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net |
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.xaml
Outdated
Show resolved
Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Content/Controls/LoadingViewSample.xaml
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.xaml
Show resolved
Hide resolved
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net |
…nt of loading/splash presenters to null
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net |
GitHub Issue (If applicable): #552
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This PR was prematurely merged #553 with DisableAnimations as the property name
What is the new behavior?
UseTransitions is more consistent with the useTransitions parameter passed to the GoToState method
Also switched visual states of both LoadingView and ExtendedSplashScreen to use VisualTransition instead of visual state storyboard so that useTransition will skip the animation.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):