Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DisableAnimations to UseTransitions #554

Merged
merged 11 commits into from
Apr 27, 2023
Merged

Rename DisableAnimations to UseTransitions #554

merged 11 commits into from
Apr 27, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #552

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

This PR was prematurely merged #553 with DisableAnimations as the property name

What is the new behavior?

UseTransitions is more consistent with the useTransitions parameter passed to the GoToState method
Also switched visual states of both LoadingView and ExtendedSplashScreen to use VisualTransition instead of visual state storyboard so that useTransition will skip the animation.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-554.eastus2.azurestaticapps.net

@agneszitte agneszitte merged commit 034b98d into main Apr 27, 2023
31 checks passed
@agneszitte agneszitte deleted the dev/nr/issue552 branch April 27, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants