Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dispatch safearea inset setter logic #567

Merged
merged 9 commits into from
Jun 5, 2023
Merged

fix: dispatch safearea inset setter logic #567

merged 9 commits into from
Jun 5, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented May 10, 2023 •
edited
Loading

relates to unoplatform/uno#12007

depends on unoplatform/uno#12246

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Screenshot_1683741881

What is the new behavior?

Screenshot_1683741883

@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 mentioned this pull request May 10, 2023
Merged
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 30, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

3 similar comments
@github-actions
Copy link

github-actions bot commented May 30, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) May 31, 2023 20:35
@github-actions
Copy link

github-actions bot commented Jun 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Jun 1, 2023

@kazo0 we should be able to move forward with this (with package bump)? as its dependency got merged

@github-actions
Copy link

github-actions bot commented Jun 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-567.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 80ebae8 into main Jun 5, 2023
31 checks passed
@kazo0 kazo0 deleted the dev/sb/safearea-android branch June 5, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@spouliot spouliot spouliot approved these changes

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kazo0 @Xiaoy312 @spouliot @agneszitte