fix: dispatch setting of visibleboundspadding insets #12246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/android 🤖
agneszitte
approved these changes
May 10, 2023
Xiaoy312
reviewed
May 10, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Xiaoy312
approved these changes
May 12, 2023
|
The build 79088 found UI Test snapshots differences: Details
|
|
The build 79088 found UI Test snapshots differences: Details
|
|
The build 79088 found UI Test snapshots differences: Details
|
|
The build 79088 found UI Test snapshots differences: Details
|
|
The build 79088 found UI Test snapshots differences: Details
|
github-actions
bot
removed
the
platform/android 🤖
|
with the analyzers, it is probably better to keep |
Xiaoy312
force-pushed
the
dev/sb/vbp-android
branch
from
122529d
to
ea3779d
Compare
@Xiaoy312 oh don't worry I'm just making garbage commits to see if it'll fix the entire UI test suite failing for Android. Having issues testing locally |
|
it didnt even compile, let alone running ci tests, since analyzers didnt like what you do lol |
kazo0
force-pushed
the
dev/sb/vbp-android
branch
2 times, most recently
from
0710532
to
e9455c9
Compare
github-actions
bot
added
the
platform/android 🤖
|
@jeromelaban yeah this is caused by a recent regression in Uno, fix is here: #12309 |
kazo0
force-pushed
the
dev/sb/vbp-android
branch
2 times, most recently
from
d7c0c70
to
f46a9bb
Compare
|
It still fails on CI, but differently this time: Is it still because of the matrix change? |
@jeromelaban nope! A new bug has been discovered :D Looks like the legacy code in the Android Window assumes that the system nav bar will always be on the right/left in Landscape/LandscapeFlipped. But it turns out that, on tablets, the nav area stays on the bottom while in Landscape[Flipped]. So it seems like this logic and the logic in the LayoutProvider has had this bug for quite some time I was running my tests locally on a phone emulator but the ci uses an emulator with width > height and in landscape mode by default |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The build 80024 found UI Test snapshots differences: Details
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jeromelaban
reviewed
May 23, 2023
github-actions
bot
added
the
area/automation
|
The build 80266 found UI Test snapshots differences: Details
|
|
@Mergifyio backport release/stable/4.8 |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12007
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?