Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NavigationBar): Add lightweight styling to Navigation bar #608

Merged
merged 2 commits into from
Jul 24, 2023
Merged

feat(NavigationBar): Add lightweight styling to Navigation bar #608

merged 2 commits into from
Jul 24, 2023

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

GitHub Issue (If applicable): #
#595
#541

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

You cannot change the color of the navbar with lightWeight styling

What is the new behavior?

Added LightWeight resources for the NavBar and fixed a fluent bug where the foreground would not change when changing theme.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review June 13, 2023 14:20
agneszitte
agneszitte reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazo0 I think it would be great for toolkit if we add another tab for SamplePageLayout to easily test the Fluent Style (right now it is only available for Material)

Similar Code from Gallery for the Fluent RadioButton @Marc-Antoine-Soucy

 <sample:SamplePageLayout.FluentTemplate>
                <DataTemplate>
                    Sample content...
                </DataTemplate>
</sample:SamplePageLayout.FluentTemplate>

@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as draft June 14, 2023 20:21
@Marc-Antoine-Soucy Marc-Antoine-Soucy self-assigned this Jun 15, 2023
@Marc-Antoine-Soucy Marc-Antoine-Soucy mentioned this pull request Jun 15, 2023
Merged
6 tasks
@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review June 21, 2023 14:16
@Marc-Antoine-Soucy
Copy link
Contributor Author

@kazo0 For this pr, there is one remaining bug that I already talked about on teams, which is that the color override from within the NavBarDictionnary overrides the value of the commandbar background. If we switch the order in which we load them, then we get the reverse problem. This is only an issue on uno platforms, not on WinUI/UWP. I think however we can still push this pr?

@agneszitte agneszitte mentioned this pull request Jul 13, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-608.eastus2.azurestaticapps.net

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/navbar branch 2 times, most recently from a8cb1da to ad74c68 Compare July 24, 2023 13:27
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-608.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-608.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-608.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-608.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 5dfeeab into main Jul 24, 2023
15 checks passed
@kazo0 kazo0 deleted the dev/maso/navbar branch July 24, 2023 21:58
@unoplatform unoplatform deleted a comment from mergify bot Jul 24, 2023
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/3x

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023 •
edited
Loading

backport legacy/3x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 24, 2023
@Marc-Antoine-Soucy @mergify
feat(NavigationBar): Add lightweight styling to Navigation bar (#608)
56686d5 
* style: fix tabs

* feat(NavigationBar): Add lightweight styling to Navigation bar

(cherry picked from commit 5dfeeab)
@mergify mergify bot mentioned this pull request Jul 24, 2023
Merged
agneszitte pushed a commit that referenced this pull request Jul 24, 2023
@mergify @Marc-Antoine-Soucy
feat(NavigationBar): Add lightweight styling to Navigation bar (#608) (…
454e0b4 
…#678)

* style: fix tabs

* feat(NavigationBar): Add lightweight styling to Navigation bar

(cherry picked from commit 5dfeeab)

Co-authored-by: Marc-Antoine-Soucy <90481654+Marc-Antoine-Soucy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@agneszitte agneszitte Awaiting requested review from agneszitte

Assignees

@Marc-Antoine-Soucy Marc-Antoine-Soucy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Marc-Antoine-Soucy @agneszitte @kazo0