Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support all IconElements for native NavBar #631

Closed
wants to merge 2 commits into from
Closed

feat: Support all IconElements for native NavBar #631

wants to merge 2 commits into from

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Jun 30, 2023

fixes #623

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Only BitmapIcons are supported in the Android and iOS native NavigationBar renderers

What is the new behavior?

All IconElements are supported

Youssef1313
Youssef1313 reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that exactly a copy of what we have in uno? Could the code be re-used instead of duplicated? (InternalsVisibleTo for example)

@kazo0
Copy link
Contributor Author

kazo0 commented Jun 30, 2023

Isn't that exactly a copy of what we have in uno? Could the code be re-used instead of duplicated? (InternalsVisibleTo for example)

@Youssef1313 yes, I wasn't allowed to make InternalsVisibleTo the Toolkit :(

@ADD-Eugenio-Lopez ADD-Eugenio-Lopez mentioned this pull request Jul 27, 2023
Closed
agneszitte
agneszitte reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for this ?

@kazo0 kazo0 marked this pull request as draft August 11, 2023 22:10
@kazo0 kazo0 closed this Feb 15, 2024
@kazo0
Copy link
Contributor Author

kazo0 commented Feb 15, 2024

replaced by #1045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

Assignees

@kazo0 kazo0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazo0 @agneszitte @Youssef1313