Shadow container #638

eriklimakc · 2023-07-06T14:49:05Z

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
Docs have been added/updated
Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Contains NO breaking changes
Associated with an issue (GitHub or internal)
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

eriklimakc · 2023-07-10T15:34:11Z

The branch has been rebased from main, I'm getting some restore failures.

@Xiaoy312

doc/controls/ShadowContainer.md

src/Uno.Toolkit.UI/Controls/Shadows/Shadow.cs

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs

github-actions · 2023-07-18T20:31:11Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

jeromelaban · 2023-07-19T01:20:32Z

The sample app is now available (#638 (comment)), and below is the webassembly render. Is the clipping of the shadow expected ? /cc @eriklimakc @roubachof

eriklimakc · 2023-07-19T12:00:45Z

@jeromelaban Yes, Jean-Marie has mentioned the clipping on Android and Wasm, I think @carldebilly was the one looking into it.

unoplatform/uno#12877

github-actions · 2023-07-19T14:57:13Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

kazo0 · 2023-07-19T15:42:45Z

The neumorphic textbox looks a little funky when it is focused:

Dark theme:

Light theme:

doc/controls/ShadowContainer.md

samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.cs

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.Properties.cs

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs

Xiaoy312 · 2023-07-19T17:04:13Z

src/Uno.Toolkit.UI/Controls/Shadows/ShadowsCache.cs

+		}
+	}
+
+	private readonly ConcurrentDictionary<string, CacheBucket> _shadowsCache = new ConcurrentDictionary<string, CacheBucket>();


i felt like when the shadows are being modified, the old cache arent being removed properly..?

Xiaoy312 · 2023-07-19T17:09:21Z

src/Uno.Toolkit.UI/Controls/Shadows/ShadowsCache.cs

+
+	public void AddOrUpdate(string key, SKImage image)
+	{
+		System.Diagnostics.Debug.WriteLine($"[ShadowsCache] AddOrUpdate => key: {key}");


should be remove

Xiaoy312 · 2023-07-19T17:14:15Z

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.Paint.cs

+		if (!_shadowPropertyChanged)
+		{
+			// If a property has changed dynamically, we don't want to cache the updated shadows
+			Cache.AddOrUpdate(shadowsKey, surface.Snapshot());


the instance of surface.Snapshot() dont need any lifetime management?

samples/Directory.Packages.props

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs

github-actions · 2023-07-20T11:29:36Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

eriklimakc · 2023-07-20T12:27:44Z

About the WASM clipping, on SkiaSharp 2.88.4-preview.84 we get a better result:

@jeromelaban @roubachof

samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Converters/HexToColorConverter.cs

github-actions · 2023-07-20T13:25:08Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

src/Uno.Toolkit.UI/Controls/Shadows/ShadowCollection.cs

jeromelaban · 2023-07-20T13:28:00Z

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.Paint.cs

+		return needsPaint;
+	}
+
+#if false // ANDROID  (see comment in ShadowContainer.cs)


Do we need to keep this?

I created this issue about that: #694

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.Properties.cs

eriklimakc · 2023-07-20T16:05:48Z

Android and iOS control overlap issue: #679

roubachof · 2023-07-21T09:56:01Z

The neumorphic textbox looks a little funky when it is focused:

Dark theme:

Light theme:

@kazo0 There is no implementation of neumorphism for visual states. This is just applied on the control itself.

github-actions · 2023-07-21T16:29:20Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

github-actions · 2023-08-01T17:01:09Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

github-actions · 2023-08-01T23:20:11Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

github-actions · 2023-08-02T18:59:35Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

github-actions · 2023-08-03T13:42:47Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-638.eastus2.azurestaticapps.net

agneszitte · 2023-08-03T22:11:20Z

@eriklimakc if you can help to work on the unresolved comments we left open on another PR, please
We will sync with you tomorrow for it

agneszitte · 2023-08-04T18:09:56Z

@eriklimakc if you can help to work on the unresolved comments we left open on another PR, please We will sync with you tomorrow for it

non-cache related fixes made by @eriklimakc : chore: Addressing Shadows PR remaining comments #696
cache related fixes made by @roubachof : feat(ShadowContainer): cache cleanup based on shadows stats #698

(cc @jeromelaban)

agneszitte · 2023-08-08T17:34:38Z

https://github.com/Mergifyio backport legacy/3x

GitHub
Mergify
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

mergify · 2023-08-08T17:34:57Z

backport legacy/3x

✅ Backports have been created

#703 Shadow container (backport #638) has been created for branch legacy/3x but encountered conflicts

Co-authored-by: roubachof <jm.alfonsi@gmail.com> Co-authored-by: xiaoy312 <xiaoyao312@gmail.com> Co-authored-by: Jérôme Laban <jlaban@gmail.com> Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> (cherry picked from commit 97bc94f) # Conflicts: # build/workflow/templates/dotnet-workload-install-mac.yml # build/workflow/templates/dotnet-workload-install-windows.yml # samples/Directory.Packages.props # samples/Uno.Toolkit.WinUI.Samples/Uno.Toolkit.WinUI.Samples.Mobile/Uno.Toolkit.WinUI.Samples.Mobile.csproj # src/Uno.Toolkit.sln

Co-authored-by: roubachof <jm.alfonsi@gmail.com> Co-authored-by: xiaoy312 <xiaoyao312@gmail.com> Co-authored-by: Jérôme Laban <jlaban@gmail.com> Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> (cherry picked from commit 97bc94f)

Co-authored-by: roubachof <jm.alfonsi@gmail.com> Co-authored-by: xiaoy312 <xiaoyao312@gmail.com> Co-authored-by: Jérôme Laban <jlaban@gmail.com> Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> Co-authored-by: Érik Lima <114886335+eriklimakc@users.noreply.github.com> Co-authored-by: eriklimakc <erik.lima@knowcode.app> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>

eriklimakc force-pushed the dev/jmaf/shadow-container branch from 967585f to e8b2d35 Compare July 10, 2023 15:30

eriklimakc force-pushed the dev/jmaf/shadow-container branch 4 times, most recently from e703a9c to 18441fc Compare July 14, 2023 14:02

agneszitte requested review from kazo0, Xiaoy312, jeromelaban, roubachof and dr1rrb July 18, 2023 19:56

agneszitte reviewed Jul 18, 2023

View reviewed changes

eriklimakc mentioned this pull request Jul 19, 2023

Register corner radius property changed to ShadowContainer #662

Closed

Xiaoy312 reviewed Jul 19, 2023

View reviewed changes

jeromelaban reviewed Jul 19, 2023

View reviewed changes

samples/Directory.Packages.props Outdated Show resolved Hide resolved

src/Uno.Toolkit.UI/Controls/Shadows/ShadowContainer.cs Outdated Show resolved Hide resolved

jeromelaban reviewed Jul 20, 2023

View reviewed changes

samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Converters/HexToColorConverter.cs Show resolved Hide resolved

jeromelaban reviewed Jul 20, 2023

View reviewed changes

src/Uno.Toolkit.UI/Controls/Shadows/ShadowCollection.cs Outdated Show resolved Hide resolved

jeromelaban reviewed Jul 20, 2023

View reviewed changes

eriklimakc mentioned this pull request Jul 25, 2023

[Android][iOS]Controls overlapping over each other #679

Closed

kazo0 and others added 7 commits August 1, 2023 12:57

ci: update to 7.0.302

d44ac1b

ci: update uno.check

b30e3e0

build: remove uwp skia package

b35c472

ci: uno-check version

79676e4

fix(WinUI): Lambda func method call to avoid cast exception

713d775

docs: Adjusting Shadows docs after review

0d943a0

ci: revert unocheck version

d8d9b93

kazo0 force-pushed the dev/jmaf/shadow-container branch from dfa25df to d8d9b93 Compare August 1, 2023 16:57

Xiaoy312 force-pushed the dev/jmaf/shadow-container branch from 1905ed3 to 562455b Compare August 1, 2023 22:18

chore: remove winui specific files from uwp

ee5bf38

Xiaoy312 force-pushed the dev/jmaf/shadow-container branch from 562455b to ee5bf38 Compare August 1, 2023 23:15

build: fix csproj

ca3b4e0

Merge branch 'main' into dev/jmaf/shadow-container

6a1bff6

agneszitte merged commit 97bc94f into main Aug 3, 2023
16 checks passed

agneszitte deleted the dev/jmaf/shadow-container branch August 3, 2023 20:00

eriklimakc mentioned this pull request Aug 4, 2023

chore: Addressing Shadows PR remaining comments #696

Merged

mergify bot mentioned this pull request Aug 8, 2023

Shadow container (backport #638) #703

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shadow container #638

Shadow container #638

eriklimakc commented Jul 6, 2023

eriklimakc commented Jul 10, 2023

github-actions bot commented Jul 18, 2023 •

edited by unfurl-links bot

Loading

jeromelaban commented Jul 19, 2023

eriklimakc commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited by unfurl-links bot

Loading

kazo0 commented Jul 19, 2023

Xiaoy312 Jul 19, 2023

Xiaoy312 Jul 19, 2023

Xiaoy312 Jul 19, 2023

github-actions bot commented Jul 20, 2023 •

edited by unfurl-links bot

Loading

eriklimakc commented Jul 20, 2023

github-actions bot commented Jul 20, 2023 •

edited by unfurl-links bot

Loading

jeromelaban Jul 20, 2023

roubachof Aug 4, 2023

eriklimakc commented Jul 20, 2023

roubachof commented Jul 21, 2023

github-actions bot commented Jul 21, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 1, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 1, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 2, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 3, 2023 •

edited by unfurl-links bot

Loading

agneszitte commented Aug 3, 2023

agneszitte commented Aug 4, 2023 •

edited

Loading

agneszitte commented Aug 8, 2023 •

edited by unfurl-links bot

Loading

mergify bot commented Aug 8, 2023 •

edited

Loading

Shadow container #638

Shadow container #638

Conversation

eriklimakc commented Jul 6, 2023

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

eriklimakc commented Jul 10, 2023

github-actions bot commented Jul 18, 2023 • edited by unfurl-links bot Loading

jeromelaban commented Jul 19, 2023

eriklimakc commented Jul 19, 2023 • edited Loading

github-actions bot commented Jul 19, 2023 • edited by unfurl-links bot Loading

kazo0 commented Jul 19, 2023

Xiaoy312 Jul 19, 2023

Choose a reason for hiding this comment

Xiaoy312 Jul 19, 2023

Choose a reason for hiding this comment

Xiaoy312 Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2023 • edited by unfurl-links bot Loading

eriklimakc commented Jul 20, 2023

github-actions bot commented Jul 20, 2023 • edited by unfurl-links bot Loading

jeromelaban Jul 20, 2023

Choose a reason for hiding this comment

roubachof Aug 4, 2023

Choose a reason for hiding this comment

eriklimakc commented Jul 20, 2023

roubachof commented Jul 21, 2023

github-actions bot commented Jul 21, 2023 • edited by unfurl-links bot Loading

github-actions bot commented Aug 1, 2023 • edited by unfurl-links bot Loading

github-actions bot commented Aug 1, 2023 • edited by unfurl-links bot Loading

github-actions bot commented Aug 2, 2023 • edited by unfurl-links bot Loading

github-actions bot commented Aug 3, 2023 • edited by unfurl-links bot Loading

agneszitte commented Aug 3, 2023

agneszitte commented Aug 4, 2023 • edited Loading

agneszitte commented Aug 8, 2023 • edited by unfurl-links bot Loading

mergify bot commented Aug 8, 2023 • edited Loading

✅ Backports have been created

github-actions bot commented Jul 18, 2023 •

edited by unfurl-links bot

Loading

eriklimakc commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Jul 20, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Jul 20, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Jul 21, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 1, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 1, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 2, 2023 •

edited by unfurl-links bot

Loading

github-actions bot commented Aug 3, 2023 •

edited by unfurl-links bot

Loading

agneszitte commented Aug 4, 2023 •

edited

Loading

agneszitte commented Aug 8, 2023 •

edited by unfurl-links bot

Loading

mergify bot commented Aug 8, 2023 •

edited

Loading