chore: Addressing Shadows PR remaining comments (backport #696) #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Xiaoy312
requested changes
Aug 10, 2023
Co-authored-by: roubachof <jm.alfonsi@gmail.com> Co-authored-by: xiaoy312 <xiaoyao312@gmail.com> Co-authored-by: Jérôme Laban <jlaban@gmail.com> Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com> (cherry picked from commit 97bc94f)
Closed
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio update |
❌ Base branch update has failedmerge conflict between base and head |
pictos
force-pushed
the
mergify/bp/legacy/3x/pr-696
branch
from
e5e9691
to
4ec584b
Compare
pictos
force-pushed
the
mergify/bp/legacy/3x/pr-696
branch
from
4ec584b
to
ed1d54e
Compare
Merged
|
#739 is in a better shape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #696 done by Mergify.
Cherry-pick of 1ce1eb5 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com